1
0
mirror of https://codeberg.org/fediverse/fep.git synced 2026-08-08 13:35:51 +00:00

Validate URLs in discussionsTo and trackingIssue fields (#817)

This PR improves validation of proposal metadata. Empty strings in `discussionsTo` and `trackingIssue` fields will not be allowed.

Reviewed-on: https://codeberg.org/fediverse/fep/pulls/817
Reviewed-by: helge <helge@noreply.codeberg.org>
Co-authored-by: silverpill <silverpill@firemail.cc>
Co-committed-by: silverpill <silverpill@firemail.cc>
This commit is contained in:
silverpill
2026-04-15 21:16:14 +02:00
committed by silverpill
parent a3bd83e6cb
commit 32c3288453
+13 -2
View File
@@ -6,6 +6,15 @@ from urllib.parse import urlparse
from scripts.fep_tools import get_fep_ids, FepFile, title_to_slug
def is_valid_url(url: str):
result = urlparse(url)
if result.netloc == '':
return False
elif result.netloc.endswith(".example"):
return False
return True
@pytest.mark.parametrize("fep", get_fep_ids())
def test_fep_front_matter(fep):
fep_file = FepFile(fep)
@@ -19,11 +28,13 @@ def test_fep_front_matter(fep):
assert "discussionsTo" in parsed_frontmatter
discussions_to = parsed_frontmatter["discussionsTo"]
assert not urlparse(discussions_to).netloc.endswith(".example"), (
assert is_valid_url(discussions_to), (
"Update discussionsTo to a valid URL for a discussion topic"
)
if "trackingIssue" in parsed_frontmatter:
assert is_valid_url(parsed_frontmatter["trackingIssue"])
if parsed_frontmatter["status"] == "FINAL":
assert "dateFinalized" in parsed_frontmatter
if parsed_frontmatter["status"] == "WITHDRAWN":